feat: split convert.py into 2 modules engine_object and engine_value along with splitting of tests #1120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…along with relevant tests
georgeh0
reviewed
Oct 3, 2025
…nd imported same in engine_value
Davda-James
force-pushed
the
feat/split-convert
branch
from
45727d4 to
67e8c7a
Compare
georgeh0
reviewed
Oct 3, 2025
Member
|
This fixes #1115 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
split convert.py into 2 modules engine_object and engine_value , also split current tests into two test files test_engine_object and test_engine_value.