Feature:Add tests for json_schema.rs #1133
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #1078 by adding comprehensive test coverage for the
json_schema.rsfile, specifically testing the public APIbuild_json_schema()function.Added Dependencies
expect-test = "1.5.0"toCargo.tomlfor snapshot-based testingTest Implementation
BasicValueTypevariants includingStr,Bool,Int64,Float32,Float64,Bytes,Range,Uuid,Date,Time,LocalDateTime,OffsetDateTime,TimeDelta,Json,Vector,Union, and nullable typesTableKindvariants (UTable,KTable,LTable)Key Features
expect-testcrate as suggested in the issuebuild_json_schema()functionToJsonSchemaOptionstested🧪 Test Results
📋 Issue Requirements Met
json_schema.rsbuild_json_schema()expect_testcrate on output serialized to JSON (as suggested)🔍 Testing Approach
The implementation uses the
expect-testcrate for snapshot testing, which:expect!macroUPDATE_EXPECT=1environment variableCloses #1078
This PR provides the comprehensive test coverage requested in the issue, ensuring the
json_schema.rsfunctionality is thoroughly tested and maintainable going forward.