Skip to content

Conversation

@georgeh0
Copy link
Member

@georgeh0 georgeh0 commented Oct 6, 2025

No description provided.

@georgeh0 georgeh0 requested a review from Copilot October 6, 2025 19:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the retry mechanism to use None for unlimited retry timeouts instead of using extremely large duration values. The change makes the API more explicit and semantically correct when dealing with operations that should retry indefinitely.

  • Changed retry_timeout field from Duration to Option<Duration> in RetryOptions
  • Updated retry logic to handle None as unlimited timeout and Some(duration) for bounded retries
  • Replaced hardcoded year-long duration with None in live updater configuration

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/utils/retryable.rs Modified RetryOptions struct and retry logic to support optional timeout
src/execution/live_updater.rs Updated retry configuration to use None instead of large duration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@georgeh0 georgeh0 merged commit b992545 into main Oct 6, 2025
11 checks passed
@georgeh0 georgeh0 deleted the g/gcp-retry branch October 6, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants