Skip to content

Conversation

@georgeh0
Copy link
Member

@georgeh0 georgeh0 commented Oct 6, 2025

fixes #1154

@georgeh0 georgeh0 requested a review from Copilot October 6, 2025 21:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug where live mode source-level errors would cause the entire process to error out instead of logging the error and continuing. The fix changes error handling to log errors instead of propagating them as failures.

  • Refactored error handling in live mode to log errors instead of failing
  • Extracted reusable methods for source updating with proper error context
  • Improved code organization by moving common logic into helper methods

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@georgeh0 georgeh0 merged commit eb6fb95 into main Oct 6, 2025
12 checks passed
@georgeh0 georgeh0 deleted the g/no-refresh-errorout branch October 6, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] In interval-based refresh, a failed refresh shouldn't abandon later refreshing

2 participants