feat: Add Redis queue support for S3 event notifications #1189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Redis client dependency to Cargo.toml - Extend Amazon S3 source to support Redis pub/sub for event notifications - Add redis_url and redis_channel configuration options - Implement RedisContext with async pub/sub support - Update change_stream to prefer Redis over SQS when both are configured - Add comprehensive documentation for MinIO Redis setup - Update Python spec to include Redis configuration fields This enables MinIO users to receive S3-compatible event notifications without requiring AWS SQS, addressing issue cocoindex-io#599.
Contributor
Author
|
@georgeh0 @badmonster0 kindly help to review the PR when you have time. Thank You |
- Resolve Cargo.toml conflict by keeping Redis dependency and upstream changes - Remove old docs/docs/ops/sources.md file (replaced by separate files) - Add Redis documentation to docs/docs/sources/amazons3.md - Maintain Redis functionality with upstream changes
georgeh0
reviewed
Oct 17, 2025
- Remove timeout logic in Redis polling to prevent error masking - Wrap Redis URL and channel in dedicated RedisConfig/RedisNotification structs - Improve code organization and follow project patterns
Contributor
Author
|
@georgeh0 kindly help review the PR, I have implemented the required changes based on your feedbacks |
georgeh0
approved these changes
Oct 21, 2025
Member
|
thanks for the contribution @belloibrahv ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables MinIO users to receive S3-compatible event notifications without requiring AWS SQS, addressing issue #599.