Skip to content

fix(ollama): correctly parse nested embeddings array from ollama endpoint /api/embed #1227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 27, 2025
Merged

fix(ollama): correctly parse nested embeddings array from ollama endpoint /api/embed #1227

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1bda93d
fix: correctly parse nested embeddings array from /api/embed
CAPsMANyo Oct 27, 2025
c9530aa
fix: remove trailing newline
CAPsMANyo Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/llm/ollama.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ struct OllamaEmbeddingRequest<'a> {

#[derive(Debug, Deserialize)]
struct OllamaEmbeddingResponse {
pub embedding: Vec<f32>,
pub embeddings: Vec<Vec<f32>>,
}

const OLLAMA_DEFAULT_ADDRESS: &str = "http://localhost:11434";
Expand Down Expand Up @@ -153,10 +153,17 @@ impl LlmEmbeddingClient for Client {
)
.await
.context("Ollama API error")?;

let embedding_resp: OllamaEmbeddingResponse = resp.json().await.context("Invalid JSON")?;
Ok(super::LlmEmbeddingResponse {
embedding: embedding_resp.embedding,
})

// Extract the first embedding (index 0)
let embedding = embedding_resp
.embeddings
.into_iter()
.next()
.context("Ollama API returned no embeddings")?;

Ok(super::LlmEmbeddingResponse { embedding })
}

fn get_default_embedding_dimension(&self, model: &str) -> Option<u32> {
Expand Down
Loading