Optimize decode_vector with NumPy arrays for faster vector decoding #1244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR improves the decode_vector function in CocoIndex engine_value.py by using NP arrays for numeric vectors. Previously, decoding vectors relied on Python lists and element-wise operations, which were slower for large vectors.
Changes:
-Force numeric vectors to be converted directly to NumPy arrays.
-Handle None values for non-nullable vectors by returning zero arrays of the expected dimension.
Motivation and Context:
-Testing shows an average of 1.38× faster function run time compared to the previous implementation.
Breaking Change:
No breaking changes; behavior remains compatible with existing code.