Skip to content

Also trim leading new lines for chunks in SplitRecursively. #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
badmonster0 merged 1 commit into from
Mar 15, 2025
Merged

Also trim leading new lines for chunks in SplitRecursively. #131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/ops/functions/split_recursively.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,10 +272,18 @@ impl<'t, 's: 't> RecursiveChunker<'s> {

fn add_output(&self, range: RangeValue, output: &mut Vec<(RangeValue, &'s str)>) {
let text = range.extract_str(self.full_text);
let trimmed_text = text.trim_end();

// Trim leading new lines.
let trimmed_text = text.trim_start_matches(['\n', '\r']);
let adjusted_start = range.start + (text.len() - trimmed_text.len());

// Trim trailing whitespaces
let trimmed_text = trimmed_text.trim_end();

// Only record non-empty chunks.
if !trimmed_text.is_empty() {
output.push((
RangeValue::new(range.start, range.start + trimmed_text.len()),
RangeValue::new(adjusted_start, adjusted_start + trimmed_text.len()),
trimmed_text,
));
}
Expand Down