-
Notifications
You must be signed in to change notification settings - Fork 448
feat: Support Python 3.14 free-threaded #1357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d22e28c
support free threaded
wuxiaobai24 9ce879b
add test for free-threaed
wuxiaobai24 eed4e9b
fix abi3 and free-threaded feature
wuxiaobai24 2009757
always enable free-threaded mode by default
wuxiaobai24 8548a0d
enable abi3 feature in test
wuxiaobai24 9430429
fix test ci and Cargo.toml
wuxiaobai24 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,10 +10,10 @@ license = "Apache-2.0" | |
|
|
||
| [workspace.dependencies] | ||
| pyo3 = { version = "0.27.1", features = [ | ||
| "abi3-py311", | ||
| "auto-initialize", | ||
| "chrono", | ||
| "uuid", | ||
| "extension-module", | ||
|
||
| ] } | ||
| pythonize = "0.27.0" | ||
| pyo3-async-runtimes = { version = "0.27.0", features = ["tokio-runtime"] } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually adding
--features abi3doesn't solve the problem. We don't need this.Noticed another potential problem (made a comment below). You may remove that and have another try.
You can also run this specific command
cargo test --no-default-featureslocally to see if it works.Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that the extension-module features were causing the test failures. After removing them, the tests pass locally.