Skip to content

Conversation

@vumichien
Copy link
Contributor

This PR solved #562

Copy link
Member

@badmonster0 badmonster0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this high quality PR, especially for adding additional tests carefully!

@vumichien
Copy link
Contributor Author

vumichien commented Jun 11, 2025

@badmonster0 I'm unsure why the CI failed to create a .venv. Could you help me in rerunning the CI if necessary?. It works now after pushing some commits that altered the environment in the GitHub workflow. This is not a permanent solution; we should address the root cause in a different pull request.

@lemorage
Copy link
Contributor

lemorage commented Jun 11, 2025

@vumichien personally, I think this might be due to the python version changes (?). I found the latest successful action in #611, it used Python 3.13.3 (/opt/hostedtoolcache/Python/3.13.3/x64). However, the failed ones are using Python 3.13.4 shown in the Setup venv log (/opt/hostedtoolcache/Python/3.13.4/x64).

@vumichien vumichien force-pushed the feature/database_not_provide_cocoindex_operation branch from 3fc359d to 465ecb0 Compare June 11, 2025 14:39
@badmonster0
Copy link
Member

badmonster0 commented Jun 11, 2025

@vumichien @lemorage Thanks for debugging! This is because the symbolic .venv/bin/python in the cache is broken when a different Python version is live. #615 should solve the problem.

@badmonster0 badmonster0 merged commit 039d924 into cocoindex-io:main Jun 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants