Skip to content

Conversation

@lemorage
Copy link
Contributor

In #595 and #586, we added support for numeric types in numpy array annotations. np.uint types and np.int32 were included even though in cocoindex data types we could only handle Int64, Float64 and Float32. We achieved this by type casting.

This PR attempts to remove the casting, and only supports np.int64, np.float64 and np.float32 for consistency.

Relevant proposal: #586 (comment)

Copy link
Member

@badmonster0 badmonster0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@badmonster0 badmonster0 merged commit 0586b8e into cocoindex-io:main Jun 12, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants