feat: support scalar NumPy value encodings #620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badmonster0
reviewed
Jun 14, 2025
Contributor
Author
|
Thanks for the detailed explanations, I misunderstood a bit from the suggested proposal. I am looking into those issues. |
lemorage
force-pushed
the
handle-numpy-vector
branch
from
2c135fc to
448e3a3
Compare
Contributor
Author
|
@badmonster0 Do u have any idea why the formatting check is always failing, even though it works well locally? (cocoindex) ☁ cocoindex [handle-numpy-vector] ruff format python/cocoindex/tests/test_typing.py
1 file left unchanged
(cocoindex) ☁ cocoindex [handle-numpy-vector] ruff --version
ruff 0.6.8 |
lemorage
force-pushed
the
handle-numpy-vector
branch
from
448e3a3 to
2f4ac25
Compare
Contributor
Author
|
Turns out it is due to version diffs. |
badmonster0
reviewed
Jun 17, 2025
lemorage
force-pushed
the
handle-numpy-vector
branch
from
1b02448 to
48bbbaf
Compare
badmonster0
reviewed
Jun 17, 2025
badmonster0
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As said in #616, this PR adds support for numpy type binding at the scalar number level.
Will close #616.