Skip to content

fix(postgres): fix INSERT statements when no value fields #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2025
+8 −9
Merged

fix(postgres): fix INSERT statements when no value fields #699

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions src/ops/targets/postgres.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,8 +197,7 @@ impl ExportContext {
.map(|f| format!("\"{}\"", f.name))
.collect::<Vec<_>>()
.join(", ");
let value_fields = value_fields_schema
.iter()
let all_fields = (key_fields_schema.iter().chain(value_fields_schema.iter()))
.map(|f| format!("\"{}\"", f.name))
.collect::<Vec<_>>()
.join(", ");
Expand All @@ -211,15 +210,15 @@ impl ExportContext {
Ok(Self {
db_ref,
db_pool,
upsert_sql_prefix: format!("INSERT INTO {table_name} ({all_fields}) VALUES "),
upsert_sql_suffix: if value_fields_schema.is_empty() {
format!(" ON CONFLICT ({key_fields}) DO NOTHING;")
} else {
format!(" ON CONFLICT ({key_fields}) DO UPDATE SET {set_value_fields};")
},
delete_sql_prefix: format!("DELETE FROM {table_name} WHERE "),
key_fields_schema,
value_fields_schema,
upsert_sql_prefix: format!(
"INSERT INTO {table_name} ({key_fields}, {value_fields}) VALUES "
),
upsert_sql_suffix: format!(
" ON CONFLICT ({key_fields}) DO UPDATE SET {set_value_fields};"
),
delete_sql_prefix: format!("DELETE FROM {table_name} WHERE "),
})
}
}
Expand Down