-
Notifications
You must be signed in to change notification settings - Fork 281
feat(convert): enhance dict and struct encoding with type awareness #727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
badmonster0
merged 4 commits into
cocoindex-io:main
from
vumichien:features/binding_to_dict
Jul 13, 2025
Merged
feat(convert): enhance dict and struct encoding with type awareness #727
badmonster0
merged 4 commits into
cocoindex-io:main
from
vumichien:features/binding_to_dict
Jul 13, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badmonster0
reviewed
Jul 11, 2025
Member
badmonster0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
d1a9297 to
8a9855e
Compare
Contributor
Author
|
Thank you for your instructions. I just revised the logic and test cases |
badmonster0
reviewed
Jul 12, 2025
…tion for annotations
badmonster0
approved these changes
Jul 13, 2025
badmonster0
approved these changes
Jul 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #670