Add naming validation for flow identifiers (#779) #783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement validation module for flow names, field names, and targets - Enforce 64-char limit and alphanumeric+underscore restrictions - Prevent double-underscore prefixes (reserved for internal use) - Add comprehensive test coverage with 11 test cases - Maintain backward compatibility Fixes cocoindex-io#779
badmonster0
reviewed
Jul 21, 2025
- Remove validation functions from public API (internal use only) - Simplify exception handling - let NamingError be raised directly - Pre-compile regex patterns for performance optimization - Add field name validation in DataScope.__setitem__ - Add target name validation in DataCollector.export
Contributor
Author
|
please review if the changes are correct now or any other thing is needed to be changed |
badmonster0
reviewed
Jul 22, 2025
…ce and full_flow_name validation
badmonster0
reviewed
Jul 24, 2025
| def __init__( | ||
| self, name: str, full_name: str, engine_flow_creator: Callable[[], _engine.Flow] | ||
| ): | ||
| validate_full_flow_name(full_name) |
Member
There was a problem hiding this comment.
Probably we may move the check of validate_flow_name(name) to here too, so similar checks is triggered in the location, which makes code easier to maintain.
georgeh0
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Implements naming validation for CocoIndex flow identifiers as requested in #779.
Changes
Validation Rules
[a-zA-Z_][a-zA-Z0-9_]*Testing
All existing tests pass. No breaking changes.
Fixes #779