Skip to content

fix: make the stats more reasonable and clear #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
georgeh0 merged 1 commit into from
Aug 28, 2025
Merged

fix: make the stats more reasonable and clear #928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/execution/row_indexer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,12 +369,10 @@ impl<'a> RowIndexer<'a> {

if let Some(existing_version) = existing_version {
if output.is_some() {
if !source_version.ordinal.is_available()
|| source_version.ordinal != existing_version.ordinal
{
self.update_stats.num_updates.inc(1);
} else {
if existing_version.kind == SourceVersionKind::DifferentLogic {
self.update_stats.num_reprocesses.inc(1);
} else {
self.update_stats.num_updates.inc(1);
}
} else {
self.update_stats.num_deletions.inc(1);
Expand Down
18 changes: 17 additions & 1 deletion src/execution/stats.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,24 @@ impl std::fmt::Display for UpdateStats {
let num_reprocesses = self.num_reprocesses.get();
let num_source_rows = num_insertions + num_deletions + num_updates + num_reprocesses;
if num_source_rows > 0 {
let mut sub_messages = Vec::new();
if num_insertions > 0 {
sub_messages.push(format!("{num_insertions} ADDED"));
}
if num_deletions > 0 {
sub_messages.push(format!("{num_deletions} REMOVED"));
}
if num_reprocesses > 0 {
sub_messages.push(format!(
"{num_reprocesses} REPROCESSED due to flow or logic changes"
));
}
if num_updates > 0 {
sub_messages.push(format!("{num_updates} UPDATED in source content"));
}
messages.push(format!(
"{num_source_rows} source rows processed ({num_insertions} ADDED, {num_deletions} REMOVED, {num_updates} UPDATED, {num_reprocesses} REPROCESSED on flow or logic changes)",
"{num_source_rows} source rows processed ({})",
sub_messages.join(", "),
));
}

Expand Down
Loading