Skip to content

AvalonMM: Initial Support for Burst read/write transactions#44

Open
mawillia wants to merge 1 commit intococotb:masterfrom
mawillia:avalon_enhancements
Open

AvalonMM: Initial Support for Burst read/write transactions#44
mawillia wants to merge 1 commit intococotb:masterfrom
mawillia:avalon_enhancements

Conversation

@mawillia
Copy link
Copy Markdown

@mawillia mawillia commented Apr 1, 2022

First pass; fixes #43

Review / comments appreciated.

Copy link
Copy Markdown
Contributor

@cmarqu cmarqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, just some small stylistic things.

Incorporates suggestions from Colin.

Co-authored-by: Colin Marquardt <cmarqu42@gmail.com>
@mawillia mawillia force-pushed the avalon_enhancements branch from c372a86 to b883c1c Compare April 2, 2022 10:47
@cmarqu
Copy link
Copy Markdown
Contributor

cmarqu commented Apr 2, 2022

Would it be possible to implement a test for this in https://github.com/cocotb/cocotb-bus/blob/master/tests/test_cases/test_avalon/test_avalon.py?

@mawillia
Copy link
Copy Markdown
Author

mawillia commented Apr 2, 2022

I understand what you are asking for. At the moment the test_avalon.py really only tests the AvalonMemory slave python class. There isn't anything that tests any of the AvalonMM driver class. To test that out, would need a different HDL design block that implemented the slave side of the Avalon MM bus (I've done that for IP my company is developing, but can't share it yet). I might be able to get something like that together, but it will take a little weekend time. Is VHDL acceptable or only Verilog for the designs section of the repository? What simulators do you normally test with (I am using Intel's version of Questa)? I'm not a strong verilog guy, but if you back me into a corner I could probably pull something together.

I am planning to add additional capability to the AvalonMM to support additional testing (e.g., handling parameterized read latency, byte enables for writes, etc.).

@themperek
Copy link
Copy Markdown
Contributor

@mawillia We can add GHDL for testing here. Possibly even Questa but this is a bit more involved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support AvalonMM burst read and writes.

3 participants