-
Notifications
You must be signed in to change notification settings - Fork 10
feat: Add trivy along with Add support for download-based tools PLUTO-1360 PLUTO-1361 #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…nhance installation logic
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
| // Check if this is a download-based tool (like trivy) or a runtime-based tool (like eslint) | ||
| if toolInfo.DownloadURL != "" { | ||
| // This is a download-based tool | ||
| return installDownloadBasedTool(toolInfo) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return ❤️ 🥲
…action directory - Changed installation process to extract files directly to the installation directory. - Removed unnecessary creation and cleanup of a temporary extraction directory. - Added logic to ensure all binaries are executable after installation. - Updated error messages for clarity.
2c21dd6 to
a98b899
Compare
|
Also implements PLUTO-1360 and closes #32 |
a98b899 to
a6279a9
Compare
machadoit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
No description provided.