fix: Remove runtime check for subcategories #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original adding of the require was not justified so we are removing it. It it causing problems as there are some changes on some Patterns (with AI augment) that some patterns that now are not category Security and still have subcategories
|
When we added this check it was because in Codacy subcategory was specifically "Security subcategory" and was only possible for Security patterns to have subcategory. |
|
So maybe there is code that fails elsewhere if we remove this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original adding of the require was not justified so we are removing it. It it causing problems as there are some changes on some Patterns (with AI augment) that some patterns that now are not category Security and still have subcategories
@lolgab do you have any ideia why it was added as part of #46 or what it could imply?