fix: impl nested account name deduplication #953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AvhiMaz <[email protected]>
🦋 Changeset detectedLatest commit: df5873a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lorisleiva
reviewed
Dec 11, 2025
Member
lorisleiva
left a comment
lorisleiva
left a comment
There was a problem hiding this comment.
Thank you for tackling this issue in a way that doesn't add breaking changes.
I've made a few comments but this is very close to be mergeable. Would you mind also adding a patch changeset by running changeset locally and following the prompts?
Signed-off-by: AvhiMaz <[email protected]>
lorisleiva
reviewed
Dec 11, 2025
Member
lorisleiva
left a comment
lorisleiva
left a comment
There was a problem hiding this comment.
Thanks for the changes, made a few more comments regarding the tests. 🙏
packages/nodes-from-anchor/test/v01/InstructionAccountNode.test.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: AvhiMaz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically prefix nested account names with their parent group name
when duplicates are detected, preventing invalid TypeScript output.
Only applies prefixing when necessary, preserving original names otherwise.
Fixes #754