Amiyah Jones , Feature/lesson 07 : functions, loops, and statements #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accidentally removed my work the 1st time by merging
feat: began creating an if statement for compareStrings
changed from if(a > b) to (distance > 0)
fixed the expected return methods from if statements 'gpa >=4.0' and 'gpa >= 3.7'
made sure the sum would be 0 so every value adds to the sum
if and else if statements being fixed and arranged because of 'value' in the end.
misread the comment instructions and fixed the else statement
anthonydmays
requested changes
Oct 11, 2024
lesson_06/lib/typescript/codedifferently-instructional/package-lock.json
Outdated
Show resolved
Hide resolved
changed my original if else statement to a simple one line code
anthonydmays
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passed all tests for my functions. Putting a bookmark on factorial and fibonacciNumbers , the rest I was able to understand along with taking a single list item out of an array.