Finished Lesson_07 HW - Xavier Cruz #264
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonydmays
approved these changes
Oct 11, 2024
| return "F"; | ||
| console.log(gpa); | ||
| switch ( | ||
| true // better way to do this. want to use the equivilent of a Java Map (XavierCruz5106) |
There was a problem hiding this comment.
Interesting solution, though I wouldn't argue this is better than just using if statements (need a couple more lines of code for this construction). Nice though.
There was a problem hiding this comment.
I agree it was the first solution that came to my head. the second was to use something like a java esque map of some sort and do a lookup instead of a comparison but im not sure how maps work in typescript so ive stray away from that approach
| @@ -57,7 +98,11 @@ export function computeFactorial(n: number): number { | |||
| * @return The sum of all the values. | |||
| */ | |||
| export function addNumbers(values: number[]): number { | |||
| return 0; | |||
| let sum = 0; | |||
| values.forEach((value) => { | |||
There was a problem hiding this comment.
Would be better to use values.reduce. Know how to use it, comes in handy especially for interview prep but also IRL.
There was a problem hiding this comment.
Thanks ill look into .reduce!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.