-
Notifications
You must be signed in to change notification settings - Fork 25
Feat: Fixed two files for lesson 10 by Hummad Tanweer #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
3c9aee8
Feat: Fixed two files for lesson 10 by Hummad Tanweer
htanweer244 5bf25c7
Merge branch 'main' into lesson_10
htanweer244 c255235
resloved conflicts
htanweer244 9a1c73d
changes to loader file
htanweer244 d78519e
Feat: Fixed two files for lesson 10 by Hummad Tanweer
htanweer244 9a4fcd5
resloved conflicts
htanweer244 99f2f6c
changes to loader file
htanweer244 f894123
Merge branch 'main' into lesson_10
htanweer244 105e095
resolved merges
htanweer244 cce80e6
feat: fixing merge conflicts
htanweer244 198cea0
Merge branch 'code-differently:main' into lesson_10
htanweer244 799d231
Merge branch 'main' into lesson_10
anthonydmays File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
import csv from 'csv-parser'; | ||
import fs from 'fs'; | ||
import { Credit, MediaItem } from '../models/index.js'; | ||
import { Loader } from './loader.js'; | ||
|
||
export class HummadTanweerLoader implements Loader { | ||
getLoaderName(): string { | ||
return 'hummadtanweer'; | ||
} | ||
|
||
async loadData(): Promise<MediaItem[]> { | ||
const credits = await this.loadCredits(); | ||
const mediaItems = await this.loadMediaItems(); | ||
|
||
console.log( | ||
`Loaded ${credits.length} credits and ${mediaItems.length} media items`, | ||
); | ||
|
||
return [...mediaItems.values()]; | ||
} | ||
|
||
async loadMediaItems(): Promise<MediaItem[]> { | ||
// TODO: Implement this method. | ||
const media = []; | ||
const readable = fs | ||
.createReadStream('data/media_items.csv', 'utf-8') | ||
.pipe(csv()); | ||
for await (const row of readable) { | ||
const { id, title, type, year: realeaseYear } = row; | ||
media.push(new MediaItem(id, title, type, realeaseYear, [])); | ||
} | ||
return media; | ||
} | ||
|
||
async loadCredits(): Promise<Credit[]> { | ||
const credits = []; | ||
const readable = fs | ||
.createReadStream('data/credits.csv', 'utf-8') | ||
.pipe(csv()); | ||
for await (const row of readable) { | ||
const { media_item_id, role, name } = row; | ||
credits.push(new Credit(media_item_id, name, role)); | ||
} | ||
return credits; | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.