Feat: added content to Lesson13.java - James Capparell #439
Conversation
lesson_13/maps_java/maps_app/src/main/java/com/codedifferently/lesson13/Lesson13.java
Outdated
Show resolved
Hide resolved
lesson_13/maps_ts/src/lesson13.ts
Outdated
| } | ||
| for (const key of stringS.keys()) { | ||
| if (stringT.has(key)) { | ||
| // eslint-disable-next-line @typescript-eslint/no-non-null-assertion |
There was a problem hiding this comment.
Shouldn't need to disable the assertions, please remove.
There was a problem hiding this comment.
I'll find a solution right away. I was having trouble with it yesterday and was causing an error. It was a quick fix that VS code suggested for those lines. Do you have any suggestions on how to fix it or do you think just removing the comments will work still?
There was a problem hiding this comment.
I made changes thinking that the build ran with removing those lines but it never actually pushed those changes correctly. The typescript file now has an error after removing those lines.
| } | ||
| for (const key of stringS.keys()) { | ||
| if (stringT.has(key)) { | ||
| const value1 = stringS.get(key)!; // Non-null assertion because we checked with has() |
There was a problem hiding this comment.
The error is saying you can't use ! and instead need to do something different. The documentation for the error (https://typescript-eslint.io/rules/no-non-null-assertion/) gives you an example of what you can do instead.
Re-writing as stringS.get(key) ?? -1 would work perfectly fine.
Unfortunately, the TypeScript compiler isn't smart enough yet to figure out that the has check you did on line 10 means that the check on line 11 is safe. There's probably an open feature request for this.
No description provided.