Chigazo Lesson 14 Ecommerce System #475
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ductNotFoundException; added new ProductNotFoundException for placeOrder if product is null; added new OrderNotFoundException for checkOrderStatus if order is null or cancled;
anthonydmays
approved these changes
Oct 30, 2024
| Product product = products.get(productId); | ||
| String orderId = UUID.randomUUID().toString(); | ||
| orders.put(orderId, new Order(orderId, product, quantity)); | ||
| // Asks if product is null and to throw the exception message 'Product with ID {orderId} not | ||
| // found' if it is. | ||
| if (product == null) { |
There was a problem hiding this comment.
Odd to put it here since an empty product would probably lead the Order constructor to blow up. Check your inputs before you do any work in the function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.