feat:Adds Dasia's SmartPhone Object and Test to Lesson_16 #523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried to make my folder lowercase but it wouldn't let me. |
|
Great job overall! Please review the changes requested so we can get this merged. |
anthonydmays
approved these changes
Nov 19, 2024
| @@ -0,0 +1,7 @@ | |||
| package com.codedifferently.lesson16.SmartPhone; | |||
|
|
|||
| public enum Name { | |||
There was a problem hiding this comment.
BrandName would be better.
| private int volume; | ||
|
|
||
| public SmartPhone( | ||
| Name brandName, String model, int batteryPercentage, boolean power, ArrayList<String> apps) { |
There was a problem hiding this comment.
Should be List<String> apps so that clients can pass in any implementation of a List that works for them. This meets the spirit of the dependency inversion principle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.