Feat: added Boxer.java and BoxerTest.java to create and test a class object. lesson_16 - JosephCaballero #532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…va to test it inside of a created folder boxer for lesson_16 - JosephCaballero
…r.java. lesson_16 -JosephCaballero
…-24-q4 into feature/lesson_16
VicenteVigueras
suggested changes
Nov 18, 2024
| } | ||
|
|
||
| @Test | ||
| void testRollSkillSet_testingBasicIsNotWhatIsRolled() { |
There was a problem hiding this comment.
The assertion in this test compares the SkillSet to the string "BASIC", but there are two issues:
- The
BoxerStyleenum does not have aBASICvalue. - You’re comparing an enum to a string, which isn’t valid. If
BASICwere an enum value, it should be compared asBoxerStyle.BASIC.
anthonydmays
approved these changes
Nov 23, 2024
anthonydmays
approved these changes
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Boxer.java to implement a class object and BoxerTest.java to test the methods in lesson_16 folder