Feat: adds amiyah's lesson 17 Bank ATM enhancements #543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accidentally removed my work the 1st time by merging
moves the boolean for hasBusinessOwner to simply if one owner isn't business
rm: businessCheckingAccount boolean (Its already throwing an exception in BankAtm addAccount)
already tested in BankAtmTest
includes auditLog , and methods of getting the total amount of the money order
fixed violations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BusinessCheckingAccountAuditLog: to track all transactions (debits and credits) within BankAtm.BankAtmwithout adding new public methods.Testing
BankAtmto include new functionalities.Documentation
Additional Notes
92% coverage from the test report