Skip to content

Homework 03 #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 17 commits into from
Closed

Conversation

Dlafferty251
Copy link
Contributor

I have merged Johns quiz into my homework branch

Dlafferty251 and others added 14 commits March 10, 2025 20:18
* Update README.md

* Update README.md

* Update README.md

* README.md

A'nanatawa's README

* Update README.md

* Update README.md

final updates :)

* Create .gitkeep

* Add files via upload

* Update README.md

* Update README.md

* Update README.md

* Updated README

* chore: remove unnecessary files

Signed-off-by: Anthony D. Mays <[email protected]>

---------

Signed-off-by: Anthony D. Mays <[email protected]>
Co-authored-by: Anthony D. Mays <[email protected]>
* Create README.html

* README.html

* README.html

* README.html update

* Update README.html
* Create README.md

* Create test

* Create test

* Delete lesson_00/JohnBey/test

* Add files via upload

* Delete lesson_00/JohnBey/Images/test

* Update README.md

* Rename Splatoon 3.jpg to JbeyS3.jpg

* Update README.md
* Create README.html

* Create placeholder

* Add files via upload

* Delete lesson_01/JohnBey/images/placeholder

* Create styles.css

* Rename Splatoon 3.jpg to JbeyS3.jpg

* Delete lesson_01/JohnBey/images directory

* Create placeholder

* Add files via upload

* Delete lesson_01/JohnBey/Images/placeholder
@Dlafferty251
Copy link
Contributor Author

I reverted Lesson 2 changes and I also added John and Mercedes's files into my code with the merge

import { Jbeyquiz } from './jbeyquiz.js';
import { MercedesMathewsQuiz } from './mercedes_mathews_quiz.js';

export const Quizzes = Symbol.for('Quizzes');

// Add your quiz provider here.

const QUIZ_PROVIDERS = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should only be one variable declaration for QUIZ_PROVIDERS that has all the list of providers in it, but I see duplicate declarations on lines 19 and 21. You should run npm run check to make sure things look good before you send back for review

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my goodness gracious Ill go back and fix it smh at myself

@Dlafferty251 Dlafferty251 deleted the homework_03 branch March 11, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants