-
Notifications
You must be signed in to change notification settings - Fork 23
feat/David.A_lesson7hw #326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/David.A_lesson7hw #326
Conversation
Dadenaike251
commented
Mar 21, 2025
- hw incomplete
…ike251/code-differently-25-q1 into release/David.A-lesson7hw
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your pull request names still don't meet the conventionalcommits.org standard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feature includes changes to my commit name and deletion of comment lines 43 - 52.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your pull request names still don't meet the conventionalcommits.org standard. Going to close for now, feel free to re-open and address comments and I'll update your score.
} | ||
return[]; | ||
|
||
// if (n === 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Must not have commented out code in your final PR.