Skip to content

feat/David.A_lesson7hw #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Dadenaike251
Copy link
Contributor

  • hw incomplete

Copy link
Contributor

@anthonydmays anthonydmays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your pull request names still don't meet the conventionalcommits.org standard.

@Dadenaike251 Dadenaike251 changed the title release/David.A lesson7hw feat/David.A_lesson7hw Mar 26, 2025
Copy link
Contributor Author

@Dadenaike251 Dadenaike251 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature includes changes to my commit name and deletion of comment lines 43 - 52.

Copy link
Contributor

@anthonydmays anthonydmays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your pull request names still don't meet the conventionalcommits.org standard. Going to close for now, feel free to re-open and address comments and I'll update your score.

}
return[];

// if (n === 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must not have commented out code in your final PR.

@Dadenaike251 Dadenaike251 deleted the release/David.A-lesson7hw branch April 7, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants