Feat/Adds a getConcatenation and findWordsContaining method in Java and TS #388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sful with only 1 file
anthonydmays
requested changes
Apr 2, 2025
| return ans; | ||
| } | ||
|
|
||
| public static void main(String[] args) { |
There was a problem hiding this comment.
You should not have this here. What purpose does it serve?
|
|
||
| // Runs a loop that will iterate through each character in the word. | ||
| for (int i = 0; i < words.length; i++) { | ||
| if (words[i].indexOf(x) != -1) { // will check to see if 'x' exists inside of the word |
There was a problem hiding this comment.
These comments should be on the line above the code it annotates, not after the line.
lesson_11/arrays_ts/src/lesson11.ts
Outdated
| export function getConcatenation(nums: number[]): number[] { | ||
| return []; | ||
| const n = nums.length; //Creates a variable named n that is the length of nums |
There was a problem hiding this comment.
Need to fix code formatting here, looks wrong.
lesson_11/arrays_ts/src/lesson11.ts
Outdated
| export function findWordsContaining(words: string[], x: string): number[] { | ||
| return []; | ||
| const elListo: number[] = [] //creates a new array named elListo |
There was a problem hiding this comment.
What is elListo? Fix variable name please to something more clear.
lesson_11/arrays_ts/src/lesson11.ts
Outdated
| } | ||
|
|
||
|
|
||
| //Test Cases |
There was a problem hiding this comment.
Nope, remove this and the stuff below. This code should be in formal test files.
|
Hello Anthony, I requested review because, I have put all the comments above the code they belong to, removed my useless main methods, and made variables more clear. Thank you! |
anthonydmays
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello inside this pull request you will find both Java and TS methods for getConcatenation and findWordsContaining method. You should see them inside Lesson11.java and Lesson11.ts Thank you!