Skip to content

Feat: adds ananatawa_loader to Lesson10 and modifies loaders.module.ts file #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 9, 2025

Conversation

Ananatawa
Copy link
Contributor

No description provided.

@Ananatawa Ananatawa changed the title Adds: ananatawa_loader to Lesson10 and modifies loaders.module.ts file Feat: adds ananatawa_loader to Lesson10 and modifies loaders.module.ts file Mar 31, 2025
anthonydmays
anthonydmays previously approved these changes Apr 2, 2025
Copy link
Contributor

@anthonydmays anthonydmays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your tests still aren't passing after I fixed the merge conflict.

@anthonydmays
Copy link
Contributor

Going to close for now, but feel free to reopen and fix if you want more credit.

@Ananatawa
Copy link
Contributor Author

I figured out how to get the tests to pass, but I kept getting a "Could not edit todo command" error when trying to run git push. So I force pushed to GitHub. Attached a screenshot below of the PASS tests.
Screenshot 2025-04-03 at 5 24 42 PM

@anthonydmays anthonydmays merged commit 62fd069 into code-differently:main Apr 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants