feat: implements junit tests for employee and employee manager #488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonydmays
requested changes
Apr 10, 2025
anthonydmays
requested changes
Apr 11, 2025
| assertThat(testEmployee).isEqualTo(testEmployee); | ||
| assertThat(testEmployee2).isEqualTo(testEmployee2); | ||
|
|
||
| // int actual = employees.getEmployeeCount(); |
There was a problem hiding this comment.
Cannot commit commented out code.
|
|
||
| @Test | ||
| void getIdTest() { | ||
| Employee employee1 = new Employee(1, "John", "Marketing", 50000.0); // Arrange |
There was a problem hiding this comment.
Code comment goes above the line of code it describes, not at the end of the line. Fix here and below.
| @@ -45,4 +45,9 @@ public double getSalary() { | |||
| public void setSalary(double salary) { | |||
| this.salary = salary; | |||
| } | |||
|
|
|||
| public String getDetails() { | |||
| // TODO Auto-generated method stub | |||
There was a problem hiding this comment.
Is this TODO still valid? If not, then remove.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.