chore: RMiller_lesson_15_write tests in the unit tests project #490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonydmays
requested changes
Apr 10, 2025
| + salary; | ||
| } | ||
|
|
||
| public void setDetails(int id, String name, String department, double salary) { |
There was a problem hiding this comment.
Nope, shouldn't have this here. Will allow this time, but must not have on future assignments.
There was a problem hiding this comment.
Shouldn't have any changes to this file, please revert.
There was a problem hiding this comment.
I'd like you to use the "Act, Arrange, Assert" comments to make these tests easier to read.
There was a problem hiding this comment.
You should not have needed to make any changes to this file to complete the assignment, please revert.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented tests to achieve 80% code coverage. Used AI and failed tests information to understand what to implement.