-
Notifications
You must be signed in to change notification settings - Fork 23
feat: try to add savingAccount to bankATMLesson 17 #525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
fc92fbb
feat:mbLesson_09
e42056b
Merge branch 'code-differently:main' into main
Tezz03 d7ca3b3
Merge branch 'code-differently:main' into main
Tezz03 42cbca7
Merge branch 'code-differently:main' into main
Tezz03 c57408a
Delete lesson_09/types/types_app/src/main/java/com/codedifferently/le…
Tezz03 af8eef3
Delete lesson_09/types/types_app/src/main/resources/data/montezb.json
Tezz03 7b24560
Merge branch 'code-differently:main' into main
Tezz03 d3239c0
Merge branch 'code-differently:main' into main
Tezz03 41cb92f
Merge branch 'code-differently:main' into main
Tezz03 70d28f7
Merge branch 'code-differently:main' into main
Tezz03 1dde77b
Merge branch 'code-differently:main' into main
Tezz03 74fb0ca
Merge branch 'code-differently:main' into main
Tezz03 957c931
Merge branch 'code-differently:main' into main
Tezz03 636c494
Merge branch 'code-differently:main' into main
Tezz03 f76c59d
Merge branch 'code-differently:main' into main
Tezz03 1e6771f
Feat: Need more time
9c6bf25
fix:lesson_17
4ade1fc
adding file
133525f
fix:adding a file
98052f7
fix:had to run gradle spotless apply and the tests
ba031fa
fix:made the isCheckCreationAllowed variable final in Savings Account…
3f8cffa
fix: ran gradle ./gradlew :bank_app:spotlessApply to fix the formatti…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
132 changes: 132 additions & 0 deletions
132
lesson_17/bank/bank_app/src/main/java/com/codedifferently/lesson17/bank/BankAccount.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,132 @@ | ||
package com.codedifferently.lesson17.bank; | ||
|
||
import com.codedifferently.lesson17.bank.exceptions.InsufficientFundsException; | ||
import java.util.Set; | ||
|
||
/** Represents a checking account. */ | ||
public class BankAccount { | ||
|
||
private final Set<Customer> owners; | ||
private final String accountNumber; | ||
private double balance; | ||
private boolean isActive; | ||
|
||
/** | ||
* Creates a new checking account. | ||
* | ||
* @param accountNumber The account number. | ||
* @param owners The owners of the account. | ||
* @param initialBalance The initial balance of the account. | ||
*/ | ||
// Constructor | ||
public BankAccount(String accountNumber, Set<Customer> owners, double initialBalance) { | ||
this.accountNumber = accountNumber; | ||
this.owners = owners; | ||
this.balance = initialBalance; | ||
isActive = true; | ||
} | ||
|
||
/** | ||
* Gets the account number. | ||
* | ||
* @return The account number. | ||
*/ | ||
public String getAccountNumber() { | ||
return accountNumber; | ||
} | ||
|
||
/** | ||
* Gets the owners of the account. | ||
* | ||
* @return The owners of the account. | ||
*/ | ||
public Set<Customer> getOwners() { | ||
return owners; | ||
} | ||
|
||
/** | ||
* Deposits funds into the account. | ||
* | ||
* @param amount The amount to deposit. | ||
*/ | ||
public void deposit(double amount) throws IllegalStateException { | ||
if (isClosed()) { | ||
throw new IllegalStateException("Cannot deposit to a closed account"); | ||
} | ||
if (amount <= 0) { | ||
throw new IllegalArgumentException("Deposit amount must be positive"); | ||
} | ||
balance += amount; | ||
} | ||
|
||
/** | ||
* Withdraws funds from the account. | ||
* | ||
* @param amount | ||
* @throws InsufficientFundsException | ||
*/ | ||
public void withdraw(double amount) throws InsufficientFundsException { | ||
if (isClosed()) { | ||
throw new IllegalStateException("Cannot withdraw from a closed account"); | ||
} | ||
if (amount <= 0) { | ||
throw new IllegalStateException("Withdrawal amount must be positive"); | ||
} | ||
if (balance < amount) { | ||
throw new InsufficientFundsException("Account does not have enough funds for withdrawal"); | ||
} | ||
balance -= amount; | ||
} | ||
|
||
/** | ||
* Gets the balance of the account. | ||
* | ||
* @return The balance of the account. | ||
*/ | ||
public double getBalance() { | ||
return balance; | ||
} | ||
|
||
/** Closes the account. */ | ||
public void closeAccount() throws IllegalStateException { | ||
if (balance > 0) { | ||
throw new IllegalStateException("Cannot close account with a positive balance"); | ||
} | ||
isActive = false; | ||
} | ||
|
||
/** | ||
* Checks if the account is closed. | ||
* | ||
* @return True if the account is closed, otherwise false. | ||
*/ | ||
public boolean isClosed() { | ||
return !isActive; | ||
} | ||
|
||
@Override | ||
public int hashCode() { | ||
return accountNumber.hashCode(); | ||
} | ||
|
||
@Override | ||
public boolean equals(Object obj) { | ||
if (obj instanceof BankAccount other) { | ||
return accountNumber.equals(other.accountNumber); | ||
} | ||
return false; | ||
} | ||
|
||
@Override | ||
public String toString() { | ||
return "BankAccount{" | ||
+ "accountNumber='" | ||
+ accountNumber | ||
+ '\'' | ||
+ ", balance=" | ||
+ balance | ||
+ ", isActive=" | ||
+ isActive | ||
+ '}'; | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
lesson_17/bank/bank_app/src/main/java/com/codedifferently/lesson17/bank/BusinessAccount.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
package com.codedifferently.lesson17.bank; | ||
|
||
import java.util.Set; | ||
|
||
import com.codedifferently.lesson17.bank.exceptions.InsufficientFundsException; | ||
|
||
public class BusinessAccount extends CheckingAccount { | ||
|
||
/** | ||
* Creates a new business account. | ||
* | ||
* @param accountNumber The account number. | ||
* @param owners The owners of the account. | ||
* @param initialBalance The initial balance of the account. | ||
*/ | ||
public BusinessAccount(String accountNumber, Set<Customer> owners, double initialBalance) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Need to check that one of the owners is a business, right? |
||
super(accountNumber, owners, initialBalance); | ||
} | ||
|
||
/** | ||
* Withdraws funds from the account. | ||
* | ||
* @param amount The amount to withdraw. | ||
* @throws InsufficientFundsException If there are insufficient funds in the account. | ||
*/ | ||
@Override | ||
public void withdraw(double amount) throws InsufficientFundsException { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Don't even need to override the superclass method since it does the same thing. |
||
if (amount > getBalance()) { | ||
throw new InsufficientFundsException("Insufficient funds in the account."); | ||
} | ||
super.withdraw(amount); | ||
} | ||
|
||
} |
23 changes: 23 additions & 0 deletions
23
...ank/bank_app/src/main/java/com/codedifferently/lesson17/bank/BusinessCheckingAccount.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
package com.codedifferently.lesson17.bank; | ||
|
||
import com.codedifferently.lesson17.bank.exceptions.InvalidBusinessAccountException; | ||
import java.util.Set; | ||
|
||
/** | ||
* Creates a business account. | ||
* | ||
* @param accountNumber The account number. | ||
* @param owners The owners of the account. | ||
* @param initialBalance The initial balance of the account. | ||
*/ | ||
public class BusinessCheckingAccount extends CheckingAccount { | ||
public BusinessCheckingAccount( | ||
String accountNumber, Set<Customer> owners, double initialBalance) { | ||
super(accountNumber, owners, initialBalance); | ||
|
||
boolean hasBusinessOwner = owners.stream().anyMatch(customer -> customer.isBusiness()); | ||
if (!hasBusinessOwner) { | ||
throw new InvalidBusinessAccountException("At least one owner must be a business."); | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prolly should be called
BusinessCheckingAccount
for more clarity.