Skip to content

Conversation

@DaFDE31
Copy link
Contributor

@DaFDE31 DaFDE31 commented Aug 12, 2025

No description provided.

@DaFDE31 DaFDE31 marked this pull request as ready for review August 12, 2025 15:40
Copy link
Contributor

@anthonydmays anthonydmays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎓 Automated Grading Report

Student: Danielson Adjocy
Date: 8/13/2025

Feedback

The submission includes three quiz questions, which is in line with the requirement to add questions pertaining to git, coding, GitHub, or basic computer architecture. However, the questions could be more directly related to these topics. For example, the question about what should go first in a PC frame could be more specific to computer architecture. Additionally, the answers for each question are marked as 'UNANSWERED', which does not meet the requirement that at least one answer must be correct for each question. Proper grammar and spelling are used in the questions, which is a positive aspect.

On the technical side, the student successfully created a new quiz class that implements the QuizQuestionProvider interface and named it uniquely. The class is correctly registered in the quizzes.module.ts file. However, the student commented out existing quiz imports and registrations, which is not necessary and could potentially disrupt the module's functionality. The answers are encrypted using bcrypt and configured in the quiz.yaml file, but without the correct answers being set in the quiz class, this aspect is incomplete. Overall, while the student made a good attempt, there are several areas that need improvement to fully meet the requirements.


This is an automated preliminary review. Please review and adjust before finalizing.

Copy link
Contributor

@anthonydmays anthonydmays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎓 Automated Grading Report

Student: Danielson Adjocy
Date: 8/13/2025

Feedback

The submission includes three quiz questions, but there are some issues. Two questions are relevant to computer architecture, which meets the requirement. However, the first question, 'What should go first in a pc frame?', is somewhat ambiguous and may not be directly related to the specified topics. Additionally, none of the questions have a correct answer specified, as they all use 'AnswerChoice.UNANSWERED'. This means that it's not possible for someone to provide the correct answer choice, which is a requirement. The grammar and spelling in the questions are correct, which is positive.

On the technical side, the student successfully created a new quiz class implementing the QuizQuestionProvider interface and registered it in the quizzes.module.ts file. The answers are encrypted using bcrypt and configured in the quiz.yaml file with the correct provider name. However, the student commented out other quiz imports and registrations in quizzes.module.ts, which might not be necessary and could affect other parts of the application. Overall, the technical implementation is mostly correct, but the functional aspect needs improvement to fully meet the requirements.


This is an automated preliminary review. Please review and adjust before finalizing.

@DaFDE31 DaFDE31 requested a review from anthonydmays August 14, 2025 14:37
@anthonydmays anthonydmays merged commit bfaccb6 into code-differently:main Aug 14, 2025
1 check passed
@DaFDE31 DaFDE31 deleted the feature/lesson_03/quizzes branch August 14, 2025 16:03
imo-252 pushed a commit to imo-252/code-society-25-2 that referenced this pull request Aug 15, 2025
* Added files

* update

* update

* update

* update

* update

* update

* update

* ”update”

* finished README

* fix:fixing chhange requests

* feat: add work email

* feat: added test and passing

* chore:updating

* Update quiz.yaml

* Update quiz.yaml

* revert: reverted another_quiz.ts

* Update quiz.yaml

* fix: quizzes.module.ts

---------

Co-authored-by: Danielson Adjocy <[email protected]>
anthonydmays added a commit that referenced this pull request Aug 21, 2025
* feat: define criteria for coding assignment

* feat: adds Tyrans quiz to the quizzes folder with correct bcrypt hashing (#105)

* feat: adds lesson_03 trinitiejackson quiz (#108)

* trinitie_jackson_quiz

* change closed to void

* change tag to element

* change question and answers

* add anthony_mays_quiz back

* edit spacing

---------

Co-authored-by: Trinitie Jackson <[email protected]>

* feat: adds Benjamin's completed lesson 03 hw (#107)

* feat: adds Danielson Adjocy's lesson_03 quiz (#111)

* Added files

* update

* update

* update

* update

* update

* update

* update

* ”update”

* finished README

* fix:fixing chhange requests

* feat: add work email

* feat: added test and passing

* chore:updating

* Update quiz.yaml

* Update quiz.yaml

* revert: reverted another_quiz.ts

* Update quiz.yaml

* fix: quizzes.module.ts

---------

Co-authored-by: Danielson Adjocy <[email protected]>

* feat: adds lesson_05 quiz (#151)

Signed-off-by: Anthony D. Mays <[email protected]>

* feat: added quiz check (#170)

Signed-off-by: Anthony D. Mays <[email protected]>

* feat: adds lesson_05 homework and lesson_06 pre-work (#171)

Signed-off-by: Anthony D. Mays <[email protected]>

* docs: fix bug with assignment details (#179)

Signed-off-by: Anthony D. Mays <[email protected]>

* feat: add criteria doc to martha's lesson 04 homework file

* feat: create python code file

* chore: update doc name to README

* feat: add python prime checking function to file

* feat: create JavaScript code file

* chore: adds semicolons to clean up formatting

* feat: add writeup for Martha's lesson_04 homework

---------

Signed-off-by: Anthony D. Mays <[email protected]>
Co-authored-by: Tyran Rice Jr. <[email protected]>
Co-authored-by: txjackson252 <[email protected]>
Co-authored-by: Trinitie Jackson <[email protected]>
Co-authored-by: bscott519 <[email protected]>
Co-authored-by: Danielson A. <[email protected]>
Co-authored-by: Danielson Adjocy <[email protected]>
Co-authored-by: Anthony D. Mays <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants