Skip to content

Conversation

@anthonydmays
Copy link
Contributor

  • chore: adds lesson_06 details and lesson_07 pre-work
  • chore: remove hint

Copilot AI review requested due to automatic review settings August 18, 2025 18:31
@anthonydmays anthonydmays changed the title feat/lesson 06 feat: adds lesson_06 homework and lesson_07 pre-work Aug 18, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds lesson 06 details and lesson 07 pre-work content to the code-society curriculum. It introduces a complete TypeScript expression calculator project for lesson 06 homework and sets up the framework for lesson 07's control flow topic.

  • Adds comprehensive homework assignment with Expression Calculator exercise
  • Creates complete TypeScript project structure with testing, linting, and build configuration
  • Adds lesson 07 README with pre-work video resources

Reviewed Changes

Copilot reviewed 19 out of 20 changed files in this pull request and generated 3 comments.

File Description
lesson_07/README.md Creates lesson 07 README with control flow pre-work videos and placeholder homework section
lesson_06/README.md Updates with complete homework details including Expression Calculator exercise and stretch assignment
lesson_06/expression/* Creates full TypeScript project with calculator implementation, tests, configuration files, and build setup

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

return beautify(fString || "");
};

export const printFormualaWithValues = (
Copy link

Copilot AI Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function name 'printFormualaWithValues' contains a spelling error. It should be 'printFormulaWithValues' (missing 'r' in 'formula').

Suggested change
export const printFormualaWithValues = (
export const printFormulaWithValues = (

Copilot uses AI. Check for mistakes.
@@ -0,0 +1,11 @@
export class ExpressionCalculator {
Copy link

Copilot AI Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ExpressionCalculator class should implement the Calculator interface to ensure it provides all required methods (add, multiply, divide) as expected by the tests.

Suggested change
export class ExpressionCalculator {
export class ExpressionCalculator implements Calculator {

Copilot uses AI. Check for mistakes.
/** Returns a calculation involving a, b, c, d, and e */
calculate(a: number, b: number, c: number, d: number, e: number): number {
// Implement your code here to return the correct value.
return 0;
Copy link

Copilot AI Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The calculate method returns a hardcoded 0, which will cause all tests to fail. This should be implemented to perform the actual calculation using the mathematical expression assigned to the student.

Suggested change
return 0;
// Example calculation; replace with the required expression if different.
return a + b * c - d / e;

Copilot uses AI. Check for mistakes.
@anthonydmays anthonydmays merged commit 615c47c into main Aug 18, 2025
1 check failed
@anthonydmays anthonydmays deleted the feat/lesson_06 branch August 20, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants