Feat: Brooklyn Harden feat/lesson06/version b/statement and variables #280
Conversation
anthonydmays
left a comment
anthonydmays
left a comment
There was a problem hiding this comment.
🎓 Automated Grading Report
Student: Brooklyn Harden
Date: 8/19/2025
Feedback
Brooklyn Harden has successfully met all the requirements for the assignment. The calculate method in expression_calculator.ts has been correctly implemented to perform a series of operations involving addition, power, multiplication, and division. The logic is clear and follows the expected order of operations. The .env.test file has been correctly configured with the assigned group letter 'B'. The TypeScript code is well-structured and follows consistent style guidelines, as evidenced by the successful GitHub checks. Additionally, the student has tackled the stretch assignment, implementing the isValidAlphaAbbreviation function. The function correctly interprets the abbreviation rules and handles edge cases, such as adjacent abbreviated substrings. Overall, the submission demonstrates a strong understanding of both the core and stretch requirements, with clean and efficient code.
This is an automated preliminary review. Please review and adjust before finalizing.
There was a problem hiding this comment.
Should not have lesson_04 content in this PR.
There was a problem hiding this comment.
How do I take it out?
| for(let j=0; j<abbr.length;j++){ | ||
| const abbrChar=abbr[j]; | ||
|
|
||
| /* We add 1 to shift the range, 'a'.charCodeAt(0) - 'a'.charCodeAt(0) = 0 , |
There was a problem hiding this comment.
Should use single line comments here (//).
| @@ -0,0 +1,22 @@ | |||
|
|
|||
| function isValidAlphaAbbreviation(word:string, abbr:string):boolean{ | |||
There was a problem hiding this comment.
Better to avoid abbreviations for variable names (ironic in this case, right)?
brooklynharden
deleted the
feat/lesson06/versionB/Statement_and_Variables
branch
2 participants
No description provided.