-
Notifications
You must be signed in to change notification settings - Fork 29
chore: adds additional group assignments #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Anthony D. Mays <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds three new assignment parts (F, G, and H) to the conditionals lesson, expanding the homework with additional programming exercises focused on conditional logic, loops, and basic algorithms.
- Adds three new TypeScript modules with function stubs for students to implement
- Includes comprehensive test suites for each new assignment part
- Uses environment variable-based test skipping to allow selective execution of specific homework versions
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 18 comments.
Show a summary per file
| File | Description |
|---|---|
| lesson_07/conditionals/src/part_f.ts | Adds function stubs for grade calculation, even number summation, and character counting |
| lesson_07/conditionals/src/part_f.test.ts | Comprehensive test suite for part F functions with environment-based execution control |
| lesson_07/conditionals/src/part_g.ts | Adds function stubs for finding largest numbers, palindrome detection, and birthday calculations |
| lesson_07/conditionals/src/part_g.test.ts | Complete test coverage for part G functions with conditional test execution |
| lesson_07/conditionals/src/part_h.ts | Adds function stubs for multiplication tables, GCD calculation, and temperature conversion |
| lesson_07/conditionals/src/part_h.test.ts | Thorough test suite for part H functions with environment variable controls |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| * A: 90-100, B: 80-89, C: 70-79, D: 60-69, F: below 60 | ||
| * | ||
| * @param score | ||
| * @returns |
Copilot
AI
Aug 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The @param documentation is incomplete. It should include the parameter type and description, e.g., '@param score - The numeric score to convert to a letter grade'.
| * @returns | |
| * @param {number} score - The numeric score to convert to a letter grade. | |
| * @returns {string} The letter grade corresponding to the score. |
| * A: 90-100, B: 80-89, C: 70-79, D: 60-69, F: below 60 | ||
| * | ||
| * @param score | ||
| * @returns |
Copilot
AI
Aug 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The @returns documentation is incomplete. It should describe what is returned, e.g., '@returns The letter grade (A, B, C, D, or F) corresponding to the score'.
| * @returns | |
| * @param score The numeric score to convert to a letter grade. | |
| * @returns The letter grade (A, B, C, D, or F) corresponding to the score. |
| * Calculates the sum of all even numbers in the given array. | ||
| * | ||
| * @param numbers | ||
| * @returns |
Copilot
AI
Aug 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The @param documentation is incomplete. It should include the parameter type and description, e.g., '@param numbers - Array of numbers to sum even values from'.
| * @returns | |
| * @param numbers - number[] - Array of numbers to sum even values from. | |
| * @returns number - The sum of all even numbers in the array. |
| * Calculates the sum of all even numbers in the given array. | ||
| * | ||
| * @param numbers | ||
| * @returns |
Copilot
AI
Aug 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * | ||
| * @param text | ||
| * @param character | ||
| * @returns |
Copilot
AI
Aug 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The @param documentation is incomplete. It should include the parameter type and description, e.g., '@param text - The string to search in'.
| * @returns | |
| * @param {string} text - The string to search in. | |
| * @param {string} character - The character to count occurrences of. | |
| * @returns {number} The number of times the character appears in the string. |
| * Returns an array of strings in the format "number x 1 = result". | ||
| * | ||
| * @param number | ||
| * @returns |
Copilot
AI
Aug 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The @returns documentation is incomplete. It should describe what is returned, e.g., '@returns Array of strings representing the multiplication table'.
| * @returns | |
| * @param number The number for which to generate the multiplication table | |
| * @returns Array of strings representing the multiplication table for the given number |
| * | ||
| * @param temperature | ||
| * @param fromScale | ||
| * @param toScale |
Copilot
AI
Aug 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The @param documentation is incomplete. It should include the parameter type and description, e.g., '@param temperature - The temperature value to convert'.
| * @param toScale | |
| * @param {number} temperature - The temperature value to convert. | |
| * @param {string} fromScale - The scale to convert from ("C", "F", or "K"). | |
| * @param {string} toScale - The scale to convert to ("C", "F", or "K"). |
| * @param temperature | ||
| * @param fromScale | ||
| * @param toScale | ||
| * @returns |
Copilot
AI
Aug 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The @param documentation is incomplete. It should include the parameter type and description, e.g., '@param fromScale - The source temperature scale (C, F, or K)'.
| * @returns | |
| * @param temperature {number} - The temperature value to convert. | |
| * @param fromScale {string} - The source temperature scale ("C", "F", or "K"). | |
| * @param toScale {string} - The target temperature scale ("C", "F", or "K"). | |
| * @returns {number} - The converted temperature value. |
| * @param temperature | ||
| * @param fromScale | ||
| * @param toScale | ||
| * @returns |
Copilot
AI
Aug 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The @param documentation is incomplete. It should include the parameter type and description, e.g., '@param toScale - The target temperature scale (C, F, or K)'.
| * @returns | |
| * @param temperature {number} The temperature value to convert. | |
| * @param fromScale {string} The scale to convert from ("C", "F", or "K"). | |
| * @param toScale {string} The scale to convert to ("C", "F", or "K"). | |
| * @returns {number} The converted temperature value. |
| * @param temperature | ||
| * @param fromScale | ||
| * @param toScale | ||
| * @returns |
Copilot
AI
Aug 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
) Signed-off-by: Anthony D. Mays <[email protected]>
Signed-off-by: Anthony D. Mays [email protected]