Skip to content

Conversation

@anthonydmays
Copy link
Contributor

Signed-off-by: Anthony D. Mays [email protected]

Copilot AI review requested due to automatic review settings August 20, 2025 20:39
@anthonydmays anthonydmays merged commit 888672a into main Aug 20, 2025
1 check failed
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds three new assignment parts (F, G, and H) to the conditionals lesson, expanding the homework with additional programming exercises focused on conditional logic, loops, and basic algorithms.

  • Adds three new TypeScript modules with function stubs for students to implement
  • Includes comprehensive test suites for each new assignment part
  • Uses environment variable-based test skipping to allow selective execution of specific homework versions

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 18 comments.

Show a summary per file
File Description
lesson_07/conditionals/src/part_f.ts Adds function stubs for grade calculation, even number summation, and character counting
lesson_07/conditionals/src/part_f.test.ts Comprehensive test suite for part F functions with environment-based execution control
lesson_07/conditionals/src/part_g.ts Adds function stubs for finding largest numbers, palindrome detection, and birthday calculations
lesson_07/conditionals/src/part_g.test.ts Complete test coverage for part G functions with conditional test execution
lesson_07/conditionals/src/part_h.ts Adds function stubs for multiplication tables, GCD calculation, and temperature conversion
lesson_07/conditionals/src/part_h.test.ts Thorough test suite for part H functions with environment variable controls

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

* A: 90-100, B: 80-89, C: 70-79, D: 60-69, F: below 60
*
* @param score
* @returns
Copy link

Copilot AI Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @param documentation is incomplete. It should include the parameter type and description, e.g., '@param score - The numeric score to convert to a letter grade'.

Suggested change
* @returns
* @param {number} score - The numeric score to convert to a letter grade.
* @returns {string} The letter grade corresponding to the score.

Copilot uses AI. Check for mistakes.
* A: 90-100, B: 80-89, C: 70-79, D: 60-69, F: below 60
*
* @param score
* @returns
Copy link

Copilot AI Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @returns documentation is incomplete. It should describe what is returned, e.g., '@returns The letter grade (A, B, C, D, or F) corresponding to the score'.

Suggested change
* @returns
* @param score The numeric score to convert to a letter grade.
* @returns The letter grade (A, B, C, D, or F) corresponding to the score.

Copilot uses AI. Check for mistakes.
* Calculates the sum of all even numbers in the given array.
*
* @param numbers
* @returns
Copy link

Copilot AI Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @param documentation is incomplete. It should include the parameter type and description, e.g., '@param numbers - Array of numbers to sum even values from'.

Suggested change
* @returns
* @param numbers - number[] - Array of numbers to sum even values from.
* @returns number - The sum of all even numbers in the array.

Copilot uses AI. Check for mistakes.
* Calculates the sum of all even numbers in the given array.
*
* @param numbers
* @returns
Copy link

Copilot AI Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @returns documentation is incomplete. It should describe what is returned, e.g., '@returns The sum of all even numbers in the array'.

Suggested change
* @returns
* @param numbers The array of numbers to process.
* @returns The sum of all even numbers in the array.

Copilot uses AI. Check for mistakes.
*
* @param text
* @param character
* @returns
Copy link

Copilot AI Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @param documentation is incomplete. It should include the parameter type and description, e.g., '@param text - The string to search in'.

Suggested change
* @returns
* @param {string} text - The string to search in.
* @param {string} character - The character to count occurrences of.
* @returns {number} The number of times the character appears in the string.

Copilot uses AI. Check for mistakes.
* Returns an array of strings in the format "number x 1 = result".
*
* @param number
* @returns
Copy link

Copilot AI Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @returns documentation is incomplete. It should describe what is returned, e.g., '@returns Array of strings representing the multiplication table'.

Suggested change
* @returns
* @param number The number for which to generate the multiplication table
* @returns Array of strings representing the multiplication table for the given number

Copilot uses AI. Check for mistakes.
*
* @param temperature
* @param fromScale
* @param toScale
Copy link

Copilot AI Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @param documentation is incomplete. It should include the parameter type and description, e.g., '@param temperature - The temperature value to convert'.

Suggested change
* @param toScale
* @param {number} temperature - The temperature value to convert.
* @param {string} fromScale - The scale to convert from ("C", "F", or "K").
* @param {string} toScale - The scale to convert to ("C", "F", or "K").

Copilot uses AI. Check for mistakes.
* @param temperature
* @param fromScale
* @param toScale
* @returns
Copy link

Copilot AI Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @param documentation is incomplete. It should include the parameter type and description, e.g., '@param fromScale - The source temperature scale (C, F, or K)'.

Suggested change
* @returns
* @param temperature {number} - The temperature value to convert.
* @param fromScale {string} - The source temperature scale ("C", "F", or "K").
* @param toScale {string} - The target temperature scale ("C", "F", or "K").
* @returns {number} - The converted temperature value.

Copilot uses AI. Check for mistakes.
* @param temperature
* @param fromScale
* @param toScale
* @returns
Copy link

Copilot AI Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @param documentation is incomplete. It should include the parameter type and description, e.g., '@param toScale - The target temperature scale (C, F, or K)'.

Suggested change
* @returns
* @param temperature {number} The temperature value to convert.
* @param fromScale {string} The scale to convert from ("C", "F", or "K").
* @param toScale {string} The scale to convert to ("C", "F", or "K").
* @returns {number} The converted temperature value.

Copilot uses AI. Check for mistakes.
* @param temperature
* @param fromScale
* @param toScale
* @returns
Copy link

Copilot AI Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @returns documentation is incomplete. It should describe what is returned, e.g., '@returns The converted temperature value'.

Suggested change
* @returns
* @returns The converted temperature value in the target scale.

Copilot uses AI. Check for mistakes.
@anthonydmays anthonydmays deleted the feat/lesson_07 branch August 21, 2025 17:37
jaydenellis pushed a commit to jaydenellis/jayden-ellis-code-society-25-2 that referenced this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants