-
Notifications
You must be signed in to change notification settings - Fork 29
feat/lesson07/benjaminscott/control flow statements #330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
anthonydmays
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎓 Automated Grading Report
Student: Benjamin Scott
Date: 8/21/2025
Feedback
Benjamin Scott's submission meets all the functional and technical requirements. The student correctly modified the .env.test file to set the group to 'A', which aligns with the assigned group. The functions in lesson7.ts and part_a.ts are implemented correctly and appear to fulfill the specified requirements. The compareStrings function properly returns -1, 0, or 1 based on the lexicographic distance, and the computeFactorial function handles edge cases such as negative numbers and zero correctly. The getFirstNFibonacciNumbers function returns the correct Fibonacci sequence for the given input, and the binarySearch function is implemented recursively as required. The code is well-structured and follows TypeScript conventions, contributing to a clean and consistent style. All GitHub checks have passed, indicating that the code is technically sound. However, there is no evidence of a stretch assignment attempt, so the stretch score is not applicable. Overall, this is a strong submission that demonstrates a solid understanding of the assignment requirements and TypeScript programming.
This is an automated preliminary review. Please review and adjust before finalizing.
anthonydmays
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May only submit lesson_07 work in this PR, please adjust.
I am submitting my lesson7.ts function and part_a.ts function implementations. This assignment helped me learn how to implement factorial computations, the Fibonacci sequence, and binary search. The other functions also helped me learn how to implement working control flow statements to solve specific problems in the functions.