Skip to content

Conversation

@thusser252
Copy link
Contributor

No description provided.

Copy link
Contributor

@anthonydmays anthonydmays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎓 Automated Grading Report

Student: Trishtan Husser
Date: 10/7/2025

Feedback

The submission demonstrates a solid understanding of the task requirements and API development in Java. The student added a welcome endpoint that provides useful information about the API, which is a thoughtful enhancement. However, the implementation of the CRUD operations shows some redundancy and lacks error handling in certain areas. For instance, the getItem and deleteItem methods do not handle IllegalArgumentException when converting the id to a UUID, which could lead to runtime errors if an invalid UUID is provided. Additionally, the deleteItem method uses a search operation to find the item, which is less efficient compared to directly checking for the existence of the item by its ID. The code is generally well-formatted and syntactically correct, but minor improvements in error handling and efficiency could enhance the robustness of the solution. All unit tests and GitHub checks must be verified to ensure they pass successfully.


This is an automated preliminary review. Please review and adjust before finalizing.

@anthonydmays anthonydmays reopened this Oct 8, 2025
Copy link
Contributor

@anthonydmays anthonydmays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks are failing, please fix.

}

@GetMapping("/")
public ResponseEntity<Map<String, Object>> welcome() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not in the requirements, please remove.

var response = CreateMediaItemResponse.builder().item(responseItem).build();
return ResponseEntity.ok(response);
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra line breaks

@thusser252
Copy link
Contributor Author

This is a duplicate branch of lesson23, the requested changes were made on th_lesson23. The test are now passing.

@thusser252 thusser252 closed this Oct 13, 2025
@thusser252 thusser252 deleted the th_lesson23_single_file branch October 13, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants