-
Notifications
You must be signed in to change notification settings - Fork 29
feat: Implement REST API endpoints for Library Management System #738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement REST API endpoints for Library Management System #738
Conversation
anthonydmays
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎓 Automated Grading Report
Student: Trishtan Husser
Date: 10/7/2025
Feedback
The submission demonstrates a solid understanding of the task requirements and API development in Java. The student added a welcome endpoint that provides useful information about the API, which is a thoughtful enhancement. However, the implementation of the CRUD operations shows some redundancy and lacks error handling in certain areas. For instance, the getItem and deleteItem methods do not handle IllegalArgumentException when converting the id to a UUID, which could lead to runtime errors if an invalid UUID is provided. Additionally, the deleteItem method uses a search operation to find the item, which is less efficient compared to directly checking for the existence of the item by its ID. The code is generally well-formatted and syntactically correct, but minor improvements in error handling and efficiency could enhance the robustness of the solution. All unit tests and GitHub checks must be verified to ensure they pass successfully.
This is an automated preliminary review. Please review and adjust before finalizing.
anthonydmays
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checks are failing, please fix.
| } | ||
|
|
||
| @GetMapping("/") | ||
| public ResponseEntity<Map<String, Object>> welcome() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not in the requirements, please remove.
| var response = CreateMediaItemResponse.builder().item(responseItem).build(); | ||
| return ResponseEntity.ok(response); | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra line breaks
|
This is a duplicate branch of lesson23, the requested changes were made on th_lesson23. The test are now passing. |
No description provided.