Remove test MailJet pages #68153
Open
Remove test MailJet pages #68153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of trying to understand why MailJet emails weren't sending in the PD space on production, I merged this PR which added a non-user-facing test page to see if the email could send outside the PD space and added a way to utilize DCDO to attempt to send the post-workshop MailJet email where it normally would.
The results were:
registrations_controllerThis PR removes this test code now that it's no longer needed.
Links
Jira ticket: here
Follow-up work
I think the issue has been narrowed down to needing to provide correct backup values (i.e. empty strings rather than
nil). A followup PR will provide that fix but still behind a test wall so users don't see it yet.