Skip to content

test: standardise mocks folder names #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
poltorak wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −8
Open

test: standardise mocks folder names #1209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 ...ugins/src/lighthouse/mock/fixtures/lhr.ts → ...gins/src/lighthouse/mocks/fixtures/lhr.ts
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion nx.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"!{workspaceRoot}/**/.code-pushup/**/*",
"!{projectRoot}/code-pushup.config.?(m)[jt]s",
"!{projectRoot}/code-pushup.config.bundled_*.mjs",
"!{projectRoot}/@(test|mocks|mock)/**/*",
"!{projectRoot}/@(test|mocks)/**/*",
"!{projectRoot}/**/?(*.)test.[jt]s?(x)?(.snap)",
"!{projectRoot}/**/?(*.)mocks.[jt]s?(x)",
"!{projectRoot}/**/?(*.)mock.[jt]s?(x)",
Expand Down
0 packages/nx-plugin/mock/fixtures/env.ts → packages/nx-plugin/mocks/fixtures/env.ts
View file
Open in desktop
File renamed without changes.
0 packages/nx-plugin/mock/utils/executor.ts → packages/nx-plugin/mocks/utils/executor.ts
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion packages/nx-plugin/src/executors/cli/utils.int.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { describe, expect, it, vi } from 'vitest';
import type { UploadConfig } from '@code-pushup/models';
import { normalizedExecutorContext } from '../../../mock/utils/executor.js';
import { normalizedExecutorContext } from '../../../mocks/utils/executor.js';
import * as config from '../internal/config.js';
import { parseCliExecutorOptions } from './utils.js';

Expand Down
2 changes: 1 addition & 1 deletion packages/nx-plugin/src/executors/internal/config.int.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { describe, expect } from 'vitest';
import { ENV } from '../../../mock/fixtures/env.js';
import { ENV } from '../../../mocks/fixtures/env.js';
import { uploadConfig } from './config.js';
import * as env from './env.js';

Expand Down
2 changes: 1 addition & 1 deletion packages/nx-plugin/src/executors/internal/config.unit.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { type MockInstance, describe, expect } from 'vitest';
import { osAgnosticPath } from '@code-pushup/test-utils';
import { ENV } from '../../../mock/fixtures/env.js';
import { ENV } from '../../../mocks/fixtures/env.js';
import { globalConfig, persistConfig, uploadConfig } from './config.js';

describe('globalConfig', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/nx-plugin/tsconfig.test.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"include": [
"vitest.unit.config.ts",
"vitest.int.config.ts",
"mock/**/*.ts",
"mocks/**/*.ts",
"src/**/*.test.ts",
"src/**/*.test.tsx",
"src/**/*.test.js",
Expand Down
6 changes: 3 additions & 3 deletions packages/plugin-lighthouse/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,15 +66,15 @@ For a full list of available flags check out [this document](https://peter.sh/ex

### Chrome User Data

To bootstrap Chrome with a predefined for setting we have to provide a couple of config files that we located under `<project-root>/mock/chromium-user-data`.
To bootstrap Chrome with a predefined for setting we have to provide a couple of config files that we located under `<project-root>/mocks/chromium-user-data`.
When executing Lighthouse we provide the path to this folder over the `Flag` object.

To generate initialise or edit the file structure under `chromium-user-data` do the following steps:

1. Spin up Chrome by running `npx chrome-debug --user-data-dir=./packages/plugin-lighthouse/mock/chromium-user-data`
1. Spin up Chrome by running `npx chrome-debug --user-data-dir=./packages/plugin-lighthouse/mocks/chromium-user-data`
<img width="1202" alt="chrome-blank-screen" src="./docs/images/chrome-blank-screen.png">

2. If you do this the first time you should already see content under `<project-root>/mock/chromium-user-data`
2. If you do this the first time you should already see content under `<project-root>/mocks/chromium-user-data`
3. Edit the configuration over the Chrome UI. E.g. adding a profile
4. Close chromium and open it again, and you should see chromium bootstraps as the configured user
<img width="1202" alt="chrome-blank-screen-pre-configured" src="./docs/images/chrome-blank-screen-pre-configure.png">
Expand Down