Skip to content

feat: add process exit handler #1212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
BioPhoton wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: add process exit handler #1212

BioPhoton wants to merge 5 commits into from
+478 −12

Conversation

@BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Jan 12, 2026 •
edited
Loading

related to #1197

@BioPhoton BioPhoton mentioned this pull request Jan 12, 2026
Open
@nx-cloud
Copy link

nx-cloud bot commented Jan 12, 2026 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 6950284

Command Status Duration Result
nx affected -t e2e-test --parallel=1 ✅ Succeeded 13m 52s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-12 18:42:13 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 12, 2026 •
edited
Loading

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1212

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1212

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1212

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1212

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1212

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1212

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1212

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1212

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1212

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1212

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1212

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1212

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1212

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1212

commit: 6950284

@github-actions
Copy link
Contributor

github-actions bot commented Jan 12, 2026 •
edited
Loading

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 3d307db with previous commit 7d3681c.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 37 🔴 38 ↑ +0.4
Documentation 🔴 34 🔴 34 ↓ −0.1
Code coverage 🟢 91 🟢 91 ↑ +0.1
Bug prevention 🟡 75 🟡 75 ↓ −0.1
Axe Accessibility 🟡 88 🟡 88 ↓ −0.1
Code style 🟢 99 🟢 99 –
Security 🟡 51 🟡 51 –
Updates 🟡 78 🟡 78 –
Type Safety 🟡 67 🟡 67 –
Miscellaneous 🟡 67 🟡 67 –
Accessibility 🟢 92 🟢 92 –
Best Practices 🟢 100 🟢 100 –
SEO 🟢 92 🟢 92 –
👍 2 groups improved, 👎 1 group regressed, 👍 5 audits improved, 👎 5 audits regressed, 14 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 37 🔴 38 ↑ +0.4
JSDocs coverage Documentation coverage 🔴 34 🔴 34 ↓ −0.1
Code coverage Code coverage metrics 🟢 91 🟢 91 ↑ +0.1

31 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse First Contentful Paint 🟥 3.0 s 🟥 3.1 s ↑ +2.6 %
Lighthouse Time to Interactive 🟥 13.0 s 🟥 12.7 s ↓ −2.5 %
Lighthouse Total Blocking Time 🟥 1,990 ms 🟥 1,770 ms ↓ −11.5 %
Lighthouse Speed Index 🟥 5.9 s 🟨 5.8 s ↓ −1.2 %
JSDocs coverage Types coverage 🟥 260 undocumented types 🟥 264 undocumented types ↑ +1.5 %
Code coverage Line coverage 🟨 86.2 % 🟨 86.2 % ↑ +0.1 %
JSDocs coverage Variables coverage 🟥 271 undocumented variables 🟥 274 undocumented variables ↑ +1.1 %
Code coverage Function coverage 🟩 93.4 % 🟩 93.4 % ↑ +0.1 %
Code coverage Branch coverage 🟨 87.3 % 🟨 87.3 % ↓ −0.1 %
JSDocs coverage Functions coverage 🟥 597 undocumented functions 🟥 598 undocumented functions ↑ +0.2 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,113 KiB 🟩 Total size was 2,116 KiB ↑ +0.2 %
Lighthouse Largest Contentful Paint 🟥 11.4 s 🟥 10.6 s ↓ −7 %
Lighthouse Uses efficient cache policy on static assets 🟨 31 resources found 🟨 31 resources found ↑ +0.1 %
Lighthouse Minimizes main-thread work 🟥 8.9 s 🟥 8.6 s ↓ −3.8 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −2.5 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 95 KiB 🟥 Potential savings of 95 KiB ↓ −48.3 %
Lighthouse JavaScript execution time 🟥 4.4 s 🟥 4.1 s ↓ −6.2 %
Lighthouse Server Backend Latencies 🟩 1,050 ms 🟩 840 ms ↓ −20.2 %
Lighthouse Max Potential First Input Delay 🟥 1,040 ms 🟥 880 ms ↓ −16 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 103 KiB 🟥 Potential savings of 102 KiB ↓ −31.1 %
Lighthouse Initial server response time was short 🟩 Root document took 400 ms 🟩 Root document took 360 ms ↓ −9.9 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 200 KiB 🟥 Potential savings of 223 KiB ↑ +1.9 %
Lighthouse Network Round Trip Times 🟩 0 ms 🟩 10 ms ↑ +64.4 %
JS packages Outdated npm dev dependencies. 🟨 55 outdated package versions (29 major, 19 minor, 7 patch) 🟨 56 outdated package versions (29 major, 19 minor, 8 patch) ↑ +1.8 %

655 other audits are unchanged.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 12, 2026 •
edited
Loading

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 3d307db with previous commit 7d3681c.

💼 Project utils

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Documentation 🔴 36 🔴 36 ↓ −0.1
Code coverage 🟢 94 🟢 94 ↓ −0.1

4 other categories are unchanged.

👎 2 groups regressed, 👍 2 audits improved, 👎 4 audits regressed

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
JSDocs coverage Documentation coverage 🔴 36 🔴 36 ↓ −0.1
Code coverage Code coverage metrics 🟢 94 🟢 94 ↓ −0.1

13 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
JSDocs coverage Types coverage 🟥 59 undocumented types 🟥 63 undocumented types ↑ +6.8 %
JSDocs coverage Variables coverage 🟥 43 undocumented variables 🟥 46 undocumented variables ↑ +7 %
Code coverage Branch coverage 🟩 91.8 % 🟩 91.7 % ↓ −0.1 %
Code coverage Line coverage 🟩 93.8 % 🟩 93.9 % ↑ +0.1 %
Code coverage Function coverage 🟩 95.8 % 🟩 95.9 % ↑ +0.1 %
JSDocs coverage Functions coverage 🟥 246 undocumented functions 🟥 247 undocumented functions ↑ +0.4 %

438 other audits are unchanged.

13 other projects are unchanged.

@BioPhoton BioPhoton marked this pull request as ready for review January 12, 2026 02:05
@BioPhoton BioPhoton requested a review from hanna-skryl January 12, 2026 02:22
hanna-skryl
hanna-skryl reviewed Jan 12, 2026
View reviewed changes
@BioPhoton
Copy link
Collaborator Author

BioPhoton commented Jan 12, 2026

I will add int tests now that i examined the logger code.☝️

@BioPhoton BioPhoton requested a review from hanna-skryl January 12, 2026 18:12
hanna-skryl
hanna-skryl reviewed Jan 12, 2026
View reviewed changes
packages/utils/src/lib/exit-process.int.test.ts
Comment on lines +108 to +117
it('should call onClose for normal exit', () => {
expect(() => installExitHandlers({ onClose })).not.toThrow();

(process as any).emit('exit');

expect(onClose).toHaveBeenCalledTimes(1);
expect(onClose).toHaveBeenCalledWith(undefined, { kind: 'exit' });
expect(onError).not.toHaveBeenCalled();
expect(processExitSpy).not.toHaveBeenCalled();
});
Copy link
Collaborator

@hanna-skryl hanna-skryl Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: The test emits exit without a code, but in Node.js, the exit event always receives a code. Should this be emit('exit', 0)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hanna-skryl hanna-skryl hanna-skryl left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@BioPhoton BioPhoton

Labels

🔬 testing writing tests 🧩 utils

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BioPhoton @hanna-skryl