Skip to content

Commiting mysql-connection code for review #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Commiting mysql-connection code for review #3

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
69393cc
Commiting mysql-connection code for review
code-sidd Jun 13, 2017
2edfbc5
Added arguements
code-sidd Jul 28, 2017
c3f981b
Added Arguments
code-sidd Jul 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions mysql-py/mysql-conn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,17 @@
#!/usr/bin/python

hostname = '127.0.0.1'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make this parameters dynamic ? Use a getopts like tool to parse arguments.

username = 'root'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as previous comment

password = 'redhat'
database = 'mysql'
#socket ='/tmp/mysql-master5520.sock'

# Simple routine to run a query on a database and print the results:
def Query( conn ) :
print "Printing user and hosts from the box\n"
cur = conn.cursor()
cur.execute( "SELECT user,host FROM user" )
# for row in cur :
row = cur.fetchone()
while row is not None:
print row[0], row[1]
row = cur.fetchone()
# print (row)

def index ( conn1 ) :
cur = conn1.cursor()
Expand All @@ -25,7 +20,6 @@ def index ( conn1 ) :
for row in cur :
print (row)


def data_big ( conn3 ) :
cur = conn3.cursor()
print "\n\nFind biggest db"
Expand All @@ -40,8 +34,7 @@ def data_dist ( conn4 ) :
for row in cur :
print (row)

print "======Using pymysql========"
print " "

import pymysql as my
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import should always be on the top of the file. Even though the script has a main function, imports should always go to the top.

connect = my.connect( host=hostname, user=username, passwd=password, db=database )
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be made to use a .my.cnf file ?

Query( connect )
Expand Down