Skip to content

Handle fixed point buildRebar3/buildMix builders#47

Merged
camelpunch merged 4 commits intocode-supply:mainfrom
adamcstephens:push-ssnvlnpxzuzk
Mar 31, 2026
Merged

Handle fixed point buildRebar3/buildMix builders#47
camelpunch merged 4 commits intocode-supply:mainfrom
adamcstephens:push-ssnvlnpxzuzk

Conversation

@adamcstephens
Copy link
Copy Markdown
Contributor

@adamcstephens adamcstephens commented Mar 27, 2026

We'll also need NixOS/nixpkgs#503941 to properly merge env. edit: merged and included here.

Fixes #45

@camelpunch
Copy link
Copy Markdown
Contributor

I think that build failure is due to #33 introducing cmake as a nativeBuildInputs for lazy_html. I don't think lazy_html is a cmake project. Removing that dependency makes lazy_html's build pass. @tjarratt does this sound right?

camelpunch added a commit that referenced this pull request Mar 29, 2026
lazy_html doesn't appear to be a CMake project. Listing cmake as a
nativeBuildInputs breaks when nixpkgs is bumped, as it starts getting
detected as CMake and CMake fails to find its CMakeLists.txt.

See #47
@camelpunch
Copy link
Copy Markdown
Contributor

@adamcstephens when you get a moment, please rebase. I think that commit I made to main might just make this build go through.

Flake lock file updates:

• Updated input 'nixpkgs':
    'github:nixos/nixpkgs/ffcdcf99d65c61956d882df249a9be53e5902ea5?narHash=sha256-lz718rr1BDpZBYk7%2BG8cE6wee3PiBUpn8aomG/vLLiY%3D' (2025-11-05)
  → 'github:nixos/nixpkgs/b63fe7f000adcfa269967eeff72c64cafecbbebe?narHash=sha256-CIS/4AMUSwUyC8X5g%2B5JsMRvIUL3YUfewe8K4VrbsSQ%3D' (2026-03-28)
@adamcstephens

This comment was marked as resolved.

- nixfmt-rfc-style -> nixfmt
- use a shared beamPackages everywhere
- remove confusing `with pkgs;`
@adamcstephens adamcstephens marked this pull request as ready for review March 30, 2026 18:22
@adamcstephens
Copy link
Copy Markdown
Contributor Author

Everything is passing on aarch64-darwin. Everything but tokenizers is passing on x86_64-linux, which appears to be a rust compilation failure, possibly due to that project not being touched in two years and rust moving on.

As far as the upgrade goes, I think this is good to go. I can push a commit dropping tokenizers from the fixture if you want.

@camelpunch
Copy link
Copy Markdown
Contributor

Looks great, thank you! I’ll probably merge this and take a look myself at what can be done about tokenizers.

@camelpunch
Copy link
Copy Markdown
Contributor

It looks like the easiest way to fix tokenizers is to use gcc14 for that derivation, or for all native derivations. I've tried setting stdenv to gcc14Stdenv inside the first makeRustPlatform arg, and that makes the PATH's gcc be 14, but oniguruma is still compiled with 15.

I'm at a bit of a loss as to how to untangle the spaghetti of nixpkgs, fenix et al to set the version of gcc that cargo ends up using to compile the oniguruma C bits.

I'm very tempted to just say tokenizers doesn't work anymore, though!

@camelpunch
Copy link
Copy Markdown
Contributor

Ah, digging a bit deeper that oniguruma dep is archived: https://github.com/kkos/oniguruma

@camelpunch camelpunch merged commit e10444e into code-supply:main Mar 31, 2026
0 of 2 checks passed
camelpunch added a commit that referenced this pull request Mar 31, 2026
Oniguruma is a distant dependency of tokenizers. It's been archived, and
is not compatible with gcc 15+. So, use the nixpkgs-provided oniguruma,
which solves compatibility problems its own way.

See #47 for background.
@camelpunch
Copy link
Copy Markdown
Contributor

I've requested an upstream dependency bump in tokenizers so we could eventually remove the workaround: elixir-nx/tokenizers#67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Attribute 'packageName' missing - beamModules update to fixed point

2 participants