Skip to content

Commit 36bc3c1

Browse files
committed
Merge branch '2.0.x' into 1.0.x
2 parents 3f668e2 + 51e9c3f commit 36bc3c1

File tree

2 files changed

+20
-18
lines changed

2 files changed

+20
-18
lines changed

src/Bridge/GlobalSpanListener.php

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ public function onRequest(GetResponseEvent $event)
5252
}
5353

5454
$request = $event->getRequest();
55-
$requestSpan = $this->tracer->start(
55+
$this->span = $this->tracer->start(
5656
$this->nameGenerator->generate(),
5757
[
5858
new HttpMethodTag($request->getMethod()),
@@ -61,10 +61,7 @@ public function onRequest(GetResponseEvent $event)
6161
new SymfonyComponentTag(),
6262
new SymfonyVersionTag()
6363
]
64-
);
65-
$this->span = $requestSpan->start(
66-
(int)(1000000 * $request->server->get('REQUEST_TIME_FLOAT', microtime(true)))
67-
);
64+
)->start((int)(1000000 * $request->server->get('REQUEST_TIME_FLOAT', microtime(true))));
6865

6966
return $this;
7067
}

src/Bridge/RequestSpanListener.php

Lines changed: 18 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,10 @@ public static function getSubscribedEvents()
4040

4141
public function onResponse(FilterResponseEvent $event)
4242
{
43+
if (HttpKernelInterface::MASTER_REQUEST === $event->getRequestType()) {
44+
return $this;
45+
}
46+
4347
if ($this->spans->isEmpty()) {
4448
return $this;
4549
}
@@ -50,22 +54,23 @@ public function onResponse(FilterResponseEvent $event)
5054

5155
public function onRequest(GetResponseEvent $event)
5256
{
53-
$request = $event->getRequest();
54-
$requestSpan = $this->tracer->start(
55-
$this->nameGenerator->generate(),
56-
[
57-
new HttpMethodTag($request->getMethod()),
58-
new HttpUriTag($request->getRequestUri()),
59-
new SpanKindServerTag(),
60-
new SymfonyComponentTag(),
61-
new SymfonyVersionTag()
62-
]
63-
);
6457
if (HttpKernelInterface::MASTER_REQUEST === $event->getRequestType()) {
65-
$requestSpan->start((int)(1000000 * $request->server->get('REQUEST_TIME_FLOAT', microtime(true))));
58+
return $this;
6659
}
6760

68-
$this->spans->push($requestSpan);
61+
$request = $event->getRequest();
62+
$this->spans->push(
63+
$this->tracer->start(
64+
$this->nameGenerator->generate(),
65+
[
66+
new HttpMethodTag($request->getMethod()),
67+
new HttpUriTag($request->getRequestUri()),
68+
new SpanKindServerTag(),
69+
new SymfonyComponentTag(),
70+
new SymfonyVersionTag()
71+
]
72+
)
73+
);
6974

7075
return $this;
7176
}

0 commit comments

Comments
 (0)