fix: remove redundant removeCodeBlocks call #1137
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove duplicate removeCodeBlocks() call in keyword-detector/index.ts. The detectKeywordsWithType() function already calls removeCodeBlocks() internally, so calling it before passing the text was redundant and caused unnecessary double processing.
Contributor
|
All contributors have signed the CLA. Thank you! ✅ |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Author
|
I have read the CLA Document and I hereby sign the CLA |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove duplicate removeCodeBlocks() call in keyword-detector/index.ts.
The detectKeywordsWithType() function already calls removeCodeBlocks() internally, so calling it before passing the text was redundant and caused unnecessary double processing.
Summary
removeCodeBlocks()call to avoid duplicate text processingChanges
removeCodeBlocks()wrapper inindex.tswhen callingdetectKeywordsWithType()detectKeywordsWithType()already handles code block removal internally, making the external call unnecessaryScreenshots
Testing
bun run typecheck bun testSummary by cubic
Removed a redundant removeCodeBlocks() call in keyword-detector to avoid double processing and reduce minor overhead. Behavior stays the same since detectKeywordsWithType() already removes code blocks internally.
Written for commit 9b26703. Summary will update on new commits.