feat(config): add fallback_models for model availability fallback #1237
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b57fa36811
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const parsedModel = parseModelString(actualModel) | ||
| const variantToUse = userCategories?.[args.category]?.variant ?? resolvedVariant | ||
| categoryModel = parsedModel | ||
| ? (variantToUse ? { ...parsedModel, variant: variantToUse } : parsedModel) | ||
| : undefined | ||
| } | ||
| const variantToUse = resolved.config.variant ?? resolvedVariant | ||
| categoryModel = parsedModel |
There was a problem hiding this comment.
When a category has a default variant (e.g., ultrabrain → xhigh) and the fallback chain selects a different model with its own variant (e.g., Claude → max), this line now forces the default variant because resolved.config.variant is always populated from the category defaults. That overrides resolvedVariant and can send an invalid variant to the fallback provider, causing the delegated task to fail whenever the primary model is unavailable. The previous behavior only prioritized an explicit user override; consider reverting to user-only precedence or using resolvedVariant when the model came from the fallback chain.
Useful? React with 👍 / 👎.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Allow agents and categories to specify fallback models when the preferred model is unavailable, and surface the option in schema/docs/tests.
youming-ai
force-pushed
the
feat/fallback_models-restored
branch
from
8d2aff9 to
31107ce
Compare
1 participant
What
Adds a
fallback_modelsconfig option (string | string[]) so agents/categories can select the first available model at initialization time when the preferred model is unavailable.Why
Provider connectivity and model availability vary across environments. This reduces brittle startup behavior when a single configured model cannot be used.
Changes
fallback_modelsto agent overrides and category config schema.fallback_models(viaavailableModelsor connected-providers cache) before built-in fallback chain and system default.resolvedModelis not overwritten byoverride.model.override.category.Notes
Verification
bun run typecheckbun test src/shared/model-resolver.test.ts src/agents/utils.test.ts