🏆 test: optimize test suite with FakeTimers and race condition fixes #1284
+285
−76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plan agent should only inherit model settings from prometheus, not the prompt or permission. This ensures plan agent uses OpenCode's default behavior while only overriding the model.
- Add custom FakeTimers implementation (~100 lines) - Replace all real setTimeout waits with fakeTimers.advanceBy() - Test time: 104.6s → 7.01s
…etch - Use Bun.fetch.bind(Bun) to avoid globalThis.fetch mock interference - Use Promise.all pattern for concurrent fetch/waitForCallback - Add Bun.sleep(10) in afterEach for port release
Replace 6 meaningless expect(true).toBe(true) assertions with actual getCount() verifications for test quality improvement
Remove unnecessary IIFE and destructuring, use direct spread instead
- Add custom FakeTimeouts implementation - Replace setTimeout waits with fakeTimeouts.advanceBy() - Test time reduced from ~26s to ~6.8s
code-yeongyu
changed the title
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is generated using Hephaestus.
🏆 SPECIAL PR: Test Suite Optimization
⚡ Performance Impact
todo-continuation-enforcer.test.tsexecutor.test.tscallback-server.test.tsconcurrency.test.tsTotal time saved per test run: ~117 seconds 🎉
📝 Changes
test(todo-continuation-enforcer): use FakeTimers for 15x faster testssetTimeoutwaits withfakeTimers.advanceBy()test(callback-server): fix race conditions with Promise.all and Bun.fetchBun.fetch.bind(Bun)to avoid globalThis.fetch mock interferencePromise.allpattern for concurrent operationsBun.sleep(10)cleanup in afterEachtest(concurrency): replace placeholder assertions with getCount checksexpect(true).toBe(true)with actual verificationsrefactor(config-handler): simplify planDemoteConfig creationtest(executor): use FakeTimeouts for faster tests✅ Verification